Arianne Development Meeting 2016-01-06: Difference between revisions
imported>Hendrik Brummermann |
imported>Hendrik Brummermann No edit summary |
||
| Line 11: | Line 11: | ||
All JUnit tests for Marauroa [https://travis-ci.org/arianne/marauroa] and Stendhal [https://travis-ci.org/arianne/stendhal] are passing. So before we do a new release, we can just check there. In addition, Travis will execute the test suite for each pull request and post the result directly to the pull request page. Unfortunetelly there is nice output of failed tests. So in case of failures, we have to look at the console log or execute the tests locally. |
All JUnit tests for Marauroa [https://travis-ci.org/arianne/marauroa] and Stendhal [https://travis-ci.org/arianne/stendhal] are passing. So before we do a new release, we can just check there. In addition, Travis will execute the test suite for each pull request and post the result directly to the pull request page. Unfortunetelly there is nice output of failed tests. So in case of failures, we have to look at the console log or execute the tests locally. |
||
Failed tests are reported to IRC again. We should add the [https://travis-ci.org/arianne/stendhal.svg build-passing image] and Github to [https://arianne-project.org https://arianne-project.org] and [[Stendhal Testing]]. |
|||
Failed tests are reported to IRC again. |
|||
| ⚫ | |||
<!-- |
|||
* markus: I thought about doing sth like our junit history at work |
|||
20:18hendrikBut it would be the place to invoke postman from. |
|||
20:18balaurI also like the idea of pull requests more, but for a patch you don't need an account |
|||
20:18hendrikYes, that was the idea. But that's quite a bit of work. And it's kind of boring having to develop that again from scratch. So I postponed it. |
|||
20:19hendrikPerhaps we should point out both alternatives to new contributors. Or would that be too confusing? |
|||
| ⚫ | |||
20:19*hendrik nods. |
|||
20:19markusyes, kiheru. |
|||
20:20balauri agree |
|||
20:20hendrikMarkus is refering to our testresults datenbank at work. It basically consists of a table of test runs, a table of test names, and a table of results. The result table links the other two tables. |
|||
20:21markusso we should add that to https://stendhalgame.org/wiki/How_To_Create_Patch_For_Stendhal as alternative path. |
|||
20:21markusI am thinking about possibities for jenkins to be abused for that. |
|||
20:22hendrikSo we can make database queries such as: Which tests failed this time, but were fine on the last run? Or: On which test run did the failure straigh start for this test? |
|||
20:22hendrikWe have no jenkins. |
|||
20:23markusI know :) But: If we have a "publish-only-reports"-style job, such a jenkins would not waste too much resources |
|||
20:24hendrikThis has rather low priority for me, because I assume that we will fix failing tests quickly. Not keep a large number of test unfixed for a long time. |
|||
20:24markusJust an idea to get there. But maybe needs more thinking. :) |
|||
20:25markusRegarding travis: Can we get the build status prominent in some place? |
|||
20:26hendrikhttps://travis-ci.org/arianne/stendhal.svg |
|||
20:26markusI was more aiming on embedding that badge in one of our pages |
|||
20:27hendrikWhich page? |
|||
20:28markusarianne-project.org maybe? |
|||
20:28hendrikhttps://stendhalgame.org/wiki/Stendhal_Testing ? |
|||
20:28hendrikOn the left site? |
|||
20:28markusyes, good idea :) |
|||
20:29hendrikAnd a github logo. |
|||
20:29markusyes. |
|||
20:29kiherucan't hurt to have it there. not as good as screaming about failures at irc, but at least a place where somebody will notice it hopefully |
|||
20:30hendrikI think it is "both" not "one or the other". |
|||
20:30hendrikOn the website it's basically advertisment that we are doing good work[tm]. |
|||
20:31hendrikOn IRC is were we will need it for practical reasons. |
|||
--> |
|||
Revision as of 17:16, 10 January 2016
We will meet in #arianne on irc.freenode.net, https://webchat.freenode.net/?channels=arianne on Wednesday, 6th January, 2016 at 20.00 server time (19.00 GMT)
Sourceforge, Github, Travis
In August after an extended downtime of Sourceforge, we created the Arianne organisation on Github and mirrored the Stendhal git repository. Back than the mirroring was only from Sourceforge to github, and it was done by the testserver build script once a night.
Since then we have improved the situation significantly: The mirroring is now done in both directions, and it is done almost instantaneously. This means it does not matter anymore whether commits are done to Sourceforge or Github. So we can use Github features such as pull request. And we can make use of Travis for running the JUnit test. Two way git mirror explains the details.
In addition to Stendhal, Marauroa is now on github, too.
All JUnit tests for Marauroa [1] and Stendhal [2] are passing. So before we do a new release, we can just check there. In addition, Travis will execute the test suite for each pull request and post the result directly to the pull request page. Unfortunetelly there is nice output of failed tests. So in case of failures, we have to look at the console log or execute the tests locally.
Failed tests are reported to IRC again. We should add the build-passing image and Github to https://arianne-project.org and Stendhal Testing.
We should document pull requests on How To Create Patch For Stendhal. We can recommend pull requests, but accept patches as well. For those familiar with Github pull requests are easy. But patches are simpler for the others.
Prepaing release of Marauroa 4.0
- After years of development, perception_json was merged into master.
- Release bockers are tagged with MARAUROA_03_99
- ...
Doing Sendhal releases
- At the moment I am the only person who can do a Stendhal release. If I am not available and there is an active contributor, lots of changes pill up. This is hard to review, and I assume it may be frustrating for contributors. Creating a release, however, is both complicated and time consuming.
- ...
PostgreSQL support
- Long term possible objective using JSON datatype for rpobject.object
- Adding PostgreSQL support to Marauroa is little work
- Hallo of fame script and website need to support Postgres, too.
- Website
- Website currently uses deprecated old mysql api. It needs to be rewritten using PDO anyway to be compatible with the next PHP version
- Old php mysql code and new PDO code will result in doubling the number of database connectings, and having isolated transactions.
- We can do that in (rather large) chunks by converting all the code that goes to the wiki-database first. Then the website database, and finally the game-database.